-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(self-managed): improve opensearch and irsa doc with placeholders and role mapping #4302
Conversation
Note for the reviewer, I still need to test the commands with a real infra, otherwise the content and the form is ready to be review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only reviewed the next docs, but left some smaller comments.
Overall, looks like a nice addition!
Is this in |
Hello @christinaausley, after internal review, we will add additional things, I'll send you an update when it's ready to be reviewed. |
9d7097f
to
87e207b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side 👍, thanks for the adjustments 🚀
I've double-checked the CLI commands, and everything is working. @christinaausley, could you please perform a final review? After that, we'll be good to merge. Thank you in advance! |
🧹 Preview environment for this PR has been torn down. |
@christinaausley The auto-merge feature merged the branch automatically—my mistake. Could you please review the changes and let me know if any further adjustments are needed? I've re-opened the branch. |
Description
This PR improves the IRSA instructions for Self-managed installation with the addition of placeholders and a missing instruction for OpenSearch.
it also introduces the alternative
aws cli
in tabs instead of terraform for user convenienceWhen should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).