Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hover indicator missing for create anything #3435

Closed
barmac opened this issue Feb 9, 2023 · 9 comments · Fixed by #3633
Closed

Hover indicator missing for create anything #3435

barmac opened this issue Feb 9, 2023 · 9 comments · Fixed by #3633
Assignees
@nikku
Labels
a11y bug Something isn't working
Milestone
M65

Comments

@barmac
Copy link
Contributor

barmac commented Feb 9, 2023

Describe the bug

There is no hover effect for ... tool. It is present for other tools though.

Screen.Recording.2023-02-09.at.09.32.46.mov

Steps to reproduce

  1. do this
  2. do that
  3. now this happens

Expected behavior

Hover effect is present for each of items.

Environment

  • OS: [e.g. MacOS 10.2, Windows 10]
  • Camunda Modeler Version: 5.8.0-rc.0
  • Execution Platform: [e.g. Camunda Platform, Camunda Cloud]
  • Installed plug-ins: [...]

Additional context

No response
@barmac barmac added bug Something isn't working a11y labels Feb 9, 2023
@barmac barmac mentioned this issue Feb 9, 2023
Closed
41 tasks
@smbea
Copy link
Contributor

smbea commented Feb 9, 2023

I guess this is because we import it as <img src="data:image/svg+xml...">, so the color on hover isn't applied there

@nikku
Copy link
Member

nikku commented Feb 9, 2023

We'd need to show elements as html / SVG as it looks like. Then fill=currentColor will kick in.

@barmac
Copy link
Contributor Author

barmac commented Feb 9, 2023

Note that the SVG itself seems to not use currentColor.

@smbea
Copy link
Contributor

smbea commented Feb 9, 2023

It doesn't, but it will only work if it is shown as Nico said.

@nikku nikku added the backlog Queued in backlog label Feb 15, 2023 — with bpmn-io-tasks
@smbea
Copy link
Contributor

smbea commented May 23, 2023

Fixed upstream via bpmn-io/bpmn-js-create-append-anything#7

@smbea smbea added fixed upstream Requires integration of upstream change and removed backlog Queued in backlog labels May 23, 2023
nikku pushed a commit that referenced this issue May 26, 2023
@smbea @nikku
deps: update to camunda-bpmn-js@2.5.0
4faca2c 
Closes #3510
Closes #3599
Closes #3435
Closes #3568
@nikku nikku mentioned this issue May 26, 2023
Merged
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed fixed upstream Requires integration of upstream change labels May 26, 2023
@nikku nikku added the needs review Review pending label May 26, 2023 — with bpmn-io-tasks
@nikku nikku removed the in progress Currently worked on label May 26, 2023
@nikku
Copy link
Member

nikku commented May 26, 2023

Actually still broken; needs bpmn-io/bpmn-js-create-append-anything#10 to work.

@nikku nikku added in progress Currently worked on and removed needs review Review pending labels May 26, 2023
@nikku nikku self-assigned this May 26, 2023
smbea added a commit that referenced this issue May 26, 2023
@smbea
deps: update to camunda-bpmn-js@2.5.0
fd54548 
Closes #3510
Closes #3599
Closes #3435
Closes #3568
@smbea smbea closed this as completed in 6b35df9 May 26, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label May 26, 2023
@nikku nikku reopened this May 26, 2023
@nikku nikku added the in progress Currently worked on label May 26, 2023 — with bpmn-io-tasks
@nikku
Copy link
Member

nikku commented May 26, 2023

Related is bpmn-io/bpmn-js-color-picker#27.

@nikku nikku added the fixed upstream Requires integration of upstream change label Jun 6, 2023 — with bpmn-io-tasks
@nikku nikku removed the in progress Currently worked on label Jun 6, 2023
@nikku
Copy link
Member

nikku commented Jun 6, 2023

Fixed upstream via bpmn-io/bpmn-js-create-append-anything#10 and bpmn-io/bpmn-js-color-picker#27, along with migrating our internal icon loading from image URL to HTML embedding.

@nikku
Copy link
Member

nikku commented Jun 6, 2023

Closed via 1789ad2.

@nikku nikku added this to the M65 milestone Jun 6, 2023
@nikku nikku closed this as completed Jun 6, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the fixed upstream Requires integration of upstream change label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
a11y bug Something isn't working
Projects
None yet
Milestone
M65
Development

Successfully merging a pull request may close this issue.

Filter template ids in popup menu entries camunda/camunda-modeler
3 participants
@nikku @smbea @barmac