Color on text annotation and group is barely noticable

[marco64io]

Describe the bug

When using the new color picker on a text annotation, it changes nothing, whereas the "old" picker, changes color of lines and text

Steps to reproduce

Use the new coloro picker on a text annotation

Expected behavior

The same as "old" color picker (or, if the new behavior is intended, remove the coloro picker from contextual menu of tex annotation)

Environment

Camunda Modeler 5.8 and Windows 10

Additional context

No response

[nikku]

I cannot reproduce your issue, cf. screen capture:

What exactly does not work? Could you share a screen capture yourself?

[marco64io]

I verified: the colors actually changes, but when the zoom is low the change of color of lines isn't noticeable, so the text annotation, that hasn't an area but lines only, seems not changing color. At higher zoom, the color changes as expected. I apologize for the wrong report

[marco64io]

Nevertheless it's true that the new and old color pickers have slightly different colors, as can be seen in the attached image (at left the old picker, at right the new)

[nikku]

@marco64io All good! I believe this is good evidence that we should fine tune what we shipped as an accessibility improvement (background <> foreground contrast). The result is that the border is no longer clearly set apart from black.

[nikku]

This is a side-effect of bpmn-io/bpmn-js-color-picker#9.

[barmac]

The question is whether text annotation should distinct border and background colors. My expectation would be that the usual background (=fill) color is set on the entire shape.

[marco64io]

In BPMN specification, the text annotation has an half rectangular border distinct from body, so I think that they cannot have the same color

[barmac]

Some experiments:

---

---

I like the first one but don't have strong feelings. Definitely I wouldn't decrease the contrast as in the second alternative.

[marco64io]

I prefer the second one because, in my view, is more adherent to specifications (the symbol of text annotation is an half rectangle not a whole rectangle) but, yes, in the second alternative the contrast is a bit too low

[xevien96]

Hello,
I was made aware of this issue by @barmac . I had a customer reaching out about this in regards to the annotations, but also the colouring of groups. With the colour change from bpmn-io/bpmn-js-color-picker#9 it seems like the colours are harder to keep apart from another and also from default black than before. I will include some screenshots here.

Modeler 5.2.1 - hard to see

Modeler 4.8.1 - easier to see

[xevien96]

I also like version 2, the brighter colours are easier to be told apart from default black lines.

[barmac]

Thanks for the feedback. Perhaps for the group element the lighter colors may look better with sufficient contrast ensured, but I'm not 100% sure we should change anything regarding this soon.