Update stroke colours to meet approx 7:1 contrast #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
barmac
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the stroke colours in order to increase contrast against the related fill colours.
Currently, none of the combinations meet the contrast requirements for regular text as required by WGAC 2.1, some choices (particularly orange and green) are difficult to distinguish and will pose potential issues for anyone with visual impairments.
This represents a failure to meet the following accessibility guidelines:
All stroke colours have been darkened to at least a 7:1 contrast ratio against the fill, allowing the elements to meet AAA requirements for 'regular' text and meet both success criteria 1.4.4 (minimum) and 1.4.6 (enhanced) while still providing a pleasing colour choice.
Before
After
Alternative solutions
It may be preferable to keep the outline border as-is and only modify the text and icon colours to either the darkened variants, or simply back to black.