a/snapasserts: keep track of components in validation sets #14370
+937
−236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewphelpsj
force-pushed
the
component-validation-sets-testing
branch
2 times, most recently
from
cc8af3e
to
10457c3
Compare
github-actions
bot
added
the
Needs Documentation -auto-
andrewphelpsj
force-pushed
the
component-validation-sets-testing
branch
from
10457c3
to
81baf20
Compare
andrewphelpsj
force-pushed
the
component-validation-sets-testing
branch
from
81baf20
to
4c38de1
Compare
andrewphelpsj
force-pushed
the
component-validation-sets-testing
branch
from
4c38de1
to
0f7ce29
Compare
|
This is pretty big. I did some of the refactoring in a separate commit before introducing components, but I don't know if it makes much sense as a standalone PR. Let me know if this isn't easy to review, though. |
ernestl
added
the
Needs Samuele review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable us to track components alongside snaps with validation sets.