Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): Fix broken lang attribute #14320

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aaryanporwal
Copy link
Member

@aaryanporwal aaryanporwal commented Sep 20, 2024

Done

  • Replaced lang=" en" to lang="en".
  • This fixes the accessibility error "Language missing or invalid" detected using WAVE.

QA

  • Check out this feature branch
  • Run the site using the command ./run serve or dotrun
  • View the site locally in your web browser at: http://0.0.0.0:8001/
    • Be sure to test on mobile, tablet and desktop screen sizes
  • Check markup of any website on ubuntu.com and check if lang attribute is correctly set and valid.

Issue / Card

Fixes #

Screenshots

image

Help

QA steps - Commit guidelines

@webteam-app
Copy link

@aaryanporwal aaryanporwal marked this pull request as ready for review September 20, 2024 16:42
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.63%. Comparing base (0fa28b1) to head (bd76f5e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14320   +/-   ##
=======================================
  Coverage   69.63%   69.63%           
=======================================
  Files         120      120           
  Lines        3418     3418           
  Branches     1178     1174    -4     
=======================================
  Hits         2380     2380           
  Misses       1013     1013           
  Partials       25       25           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants