This repository has been archived by the owner on Sep 17, 2021. It is now read-only.
feature: add interaction on line chart. #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marzolfb
reviewed
Jan 10, 2018
There was a problem hiding this comment.
Very nice - I like it.
I just have the one small typo I would like cleaned up. It would be very nice to have an extra chart in the example app that had panHandlers implementations but I'm willing to merge it without that.
One important thing, I didn't see a record of you signing the CLA. Could you do that as well, please? Thanks!
src/Line.js
Outdated
| @@ -125,6 +203,31 @@ export default class LineChart extends Component { | |||
| ); | |||
| }.bind(this) | |||
| ); | |||
|
|
|||
| // gesture line here | |||
| let guestureLine = null; | |||
There was a problem hiding this comment.
Typo on "guesture" - should be "gesture" (like you have in the comment)
|
Comments applied.
|
marzolfb
approved these changes
Jan 17, 2018
|
Thanks for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React-native-pathjs-charts team:
Hey, I was using your chart library for a while. Really handy stock charts to use and I love it.
I worked on chart interaction and tried to implement gesture on line to meet my own project requirement. And I just cleaned it up a little bit and want to share my stuff. This commit add a property
interactionwhich default to false. When turn to true. It will response with gesture.We can specify call back function in
panHandlerStart,panHandlerMove,panHandlerEnd. Each for different stage of gesture.It also have another feature called
cursorLinedefault asredcolor withwidth = 1, which will show as a vertical line on top of the chart as a cursor to indicate while the finger is pressing.Let me know what you think.
Thank you for contributing a pull request.
Please ensure that you have signed the CLA.