Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): hide helperText if invalid or warning state #1761

Merged
merged 1 commit into from
Jul 8, 2023

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented Jul 4, 2023

Related #1757

Did a quick search for helperText usage and confirmed upstream that Select should not show helper text if in the invalid or warn states. This is consistent with other inputs.

@metonym metonym requested a review from theetrain July 4, 2023 17:13
@metonym metonym merged commit 7579c03 into master Jul 8, 2023
2 checks passed
@metonym metonym deleted the fix-select-helper-text branch July 8, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant