Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Move $$restProps in Select from wrapper <div> to <select> #1807

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brunnerh
Copy link
Contributor

@brunnerh brunnerh commented Sep 3, 2023

This aligns the component with others like TextInput, NumberInput or TextArea and allows adding not explicitly defined attributes to the "main" element of the component. Unfortunately there is no real equivalent for DropDown, which is non-standard.

Maybe there could be a standardized property that exists on all inputs (like ref) for adding attributes on the root wrapper via spread, the main use case for me would be to apply layout classes to e.g. add margins.

Other changes are from formatting by lint task.
(Prettier removes manual Markdown line breaks (two trailing spaces) from JSDoc strings; turned that into paragraphs in Header.)

This aligns the component with others like `TextInput`, `NumberInput` or `TextArea` and allows adding not explicitly defined attributes to the "main" element of the component.

Other changes are from formatting by `lint` task.
(Prettier removes manual line breaks via `  ` from JSDoc strings; turned that into paragraph in `Header`.)
@theetrain
Copy link
Collaborator

This is a good suggestion that is part of #1621 "pass-through" props. Maybe after #1629 is completed these props can be overhauled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants