Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read remote pages from website's carbon-platform branch #1570

Merged
merged 6 commits into from
Jan 25, 2023

Conversation

francinelucca
Copy link
Collaborator

Related carbon-design-system/carbon-website#3339

Read remote pages from carbon-website's carbon-platform branch and add cache files

Testing / reviewing

Run locally, test remote pages to make sure they're still able to render, should match production environment

@francinelucca francinelucca changed the title Flucca/test/pull from carbon platform branch Read remote pages from website's carbon-platform branch Jan 20, 2023
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remote pages load for me 🎉

@carbon-bot
Copy link
Contributor

The commits in this PR will result in the following version changes:

🐛 PATCH release: @carbon-platform/web-app

@sonarcloud
Copy link

sonarcloud bot commented Jan 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@francinelucca francinelucca merged commit 1a36b9a into main Jan 25, 2023
@francinelucca francinelucca deleted the flucca/test/pull-from-carbon-platform-branch branch January 25, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants