Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Why doesn't the tile on the home page of carbondesignsystem.com follow the alignment guidelines of the tile component? #2943

Closed
2 tasks done
alexandrutatarciuc opened this issue May 17, 2022 · 5 comments · Fixed by #3368

Comments

@alexandrutatarciuc
Copy link

Package

@carbon/styles

Browser

Chrome

Package version

v11.0.0

Description

The clickable tile that forwards to the migration guide to version eleven vividly doesn't follow the alignment guidelines of the tile component.
https://carbondesignsystem.com/components/tile/usage/#alignment
Here it is highlighted that the icon should be aligned to the left, while on the website it's aligned to the right.
My question is: are the guidelines outdated or is the tile on the home page implemented incorrectly?

Screenshots

image
image

Steps to reproduce

  1. Go to https://carbondesignsystem.com/
  2. Look for a big clickable tile that says Migrate to Carbon V11
  3. Compare with this https://carbondesignsystem.com/components/tile/usage/#alignment

Code of Conduct

@dakahn
Copy link
Contributor

dakahn commented May 17, 2022

@carbon-design-system/design

My guess is that the migration tile was implemented incorrectly, but @ing the team to check. Thanks for reporting.

@dakahn
Copy link
Contributor

dakahn commented May 17, 2022

@alexandrutatarciuc moving this bug over to the Carbon Website repo 👍🏾

@dakahn dakahn transferred this issue from carbon-design-system/carbon May 17, 2022
@abbeyhrt
Copy link
Contributor

We've recently been working on updating our Tile guidance and we are still working on updating the implementations. @thyhmdo fyi

@aagonzales
Copy link
Member

aagonzales commented Dec 14, 2022

Tasks

  • @thyhmdo, @oliviaflory, and @jeanservaas to discuss final decisions (dot com will need a separate issue to update their docs). What is the final decision on this?
  • Need to update the alignment section on tile page to reflect new/updated guidance of having the icon always on the right.
  • Update all images to reflect correct usage

This will then make the guidance match the website tile.

@thyhmdo
Copy link
Member

thyhmdo commented Jan 26, 2023

I'm closing this one. We had this discussion with the design team. This update will resolve this issue once it's merged.

@thyhmdo thyhmdo closed this as completed Jan 26, 2023
@aagonzales aagonzales linked a pull request Jan 27, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants