Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tile] Update content + Images for experimental tile #3368

Merged
merged 21 commits into from
Mar 3, 2023

Conversation

thyhmdo
Copy link
Member

@thyhmdo thyhmdo commented Jan 25, 2023

Will resolve #3261, #2943

  • Update the content
  • Update the image

@vercel
Copy link

vercel bot commented Jan 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 3, 2023 at 8:24PM (UTC)

Copy link
Collaborator

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some questions and change suggestions

src/pages/components/tile/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/tile/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/tile/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/tile/usage.mdx Outdated Show resolved Hide resolved
@thyhmdo
Copy link
Member Author

thyhmdo commented Jan 26, 2023

Thanks @francinelucca. Those are valid points. I haven't updated the images yet because I'm pushing that to the next sprint. That's why those old images are still there. :P

thyhmdo and others added 2 commits January 26, 2023 13:57
Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com>
Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com>
Copy link
Contributor

@jeanservaas jeanservaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Images look good, just a couple of my text changes didn't make it in:

1

image

Experimental tiles are now available. This addition enhances accessibility and only applies to the visual appearance, not the function of tiles. Though we are not deprecating the current tiles, we encourage all design teams to use the new experimental tiles in their products moving forward.

2

image

Tiles are reusable components that provide shortcuts to building cards and other modules. Use tiles to group related information in flexible containers. Here are some common use cases for when to use tiles:

3

image

Do right align the icon when there is additional text

4

All captions that are complete sentences need periods.

image

image

image

5

image

Take out the caption here (it says the same thing as the paragraph above. Change paragraph above to read:

Expandable tiles can either be triggered as a whole or contain internal CTAs only if they are given their own click targets. In these cases, the tile’s click target is reduced to only the icon button.

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Thy! Just a couple of things on the Style tab.

thyhmdo and others added 2 commits March 1, 2023 12:47
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Copy link
Collaborator

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! one anchor link detail and we should be good

src/pages/components/tile/usage.mdx Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 3e52b08 into carbon-design-system:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
5 participants