-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Radio button usage updates #2126
Radio button usage updates #2126
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/GgLxN6n747C8NcxKfzukEzxC2ut9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kingtraceyj for the description can we change the end of the sentence to read "only one selection from the group can be made." Sorry I didn't pick that up earlier. Reviewing the rest now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kingtraceyj This looks fantastic. I love the Related section. I just had a couple of very minor content tweaks. Otherwise it's fab!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job Tracey, just a couple of things!
In this image in particular, I noticed that you have two scales represented, e.g. the header bar is even smaller than that input field at the bottom of the image. So I would try to align the scale of the page content with the header so it looks more realistic as an in-context usage image.
You could either show the whole UI like Lauren does with checkbox and just scale the xlg design down to fit (I have a percentage for the 8 column images in that production file)
or just make sure you're show part of a real UI, so if any scaling is done, it's done together
Here's an example from button usage:
I'd also give these examples a little more room...
I'd match the size of the canvas to this one so it can breathe a little more
Otherwise looks great!
updated: docs and images
updated all the images
Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>
updated alignment copy
updated example image 1 and multiline image 11
bd1eab3
to
0fae4c7
Compare
Looks great! @kingtraceyj This is the tiniest little change: Right now the input field looks like it's the same height as the header bar... which would make the input field 48px when it would actually be 40px. To get the relationship right, I'd just grab both an input field and a header bar from the kit and scale them down proportionally just to get that relationship right. I'm going to approve because I'll be out next week, but just that little update and it'll be perfect!!! |
2 similar comments
Looks great! @kingtraceyj This is the tiniest little change: Right now the input field looks like it's the same height as the header bar... which would make the input field 48px when it would actually be 40px. To get the relationship right, I'd just grab both an input field and a header bar from the kit and scale them down proportionally just to get that relationship right. I'm going to approve because I'll be out next week, but just that little update and it'll be perfect!!! |
Looks great! @kingtraceyj This is the tiniest little change: Right now the input field looks like it's the same height as the header bar... which would make the input field 48px when it would actually be 40px. To get the relationship right, I'd just grab both an input field and a header bar from the kit and scale them down proportionally just to get that relationship right. I'm going to approve because I'll be out next week, but just that little update and it'll be perfect!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i had one little tweak and you made it! Great work!
* Update usage.mdx * Update usage.mdx * Update usage.mdx * Updated docs and images updated: docs and images * Radio button image update updated all the images * Update src/pages/components/radio-button/usage.mdx Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com> * Update usage.mdx updated alignment copy * Update usage.mdx * image updates updated example image 1 and multiline image 11 * updated: image Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>
* Update usage.mdx * Update usage.mdx * Update usage.mdx * Updated docs and images updated: docs and images * Radio button image update updated all the images * Update src/pages/components/radio-button/usage.mdx Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com> * Update usage.mdx updated alignment copy * Update usage.mdx * image updates updated example image 1 and multiline image 11 * updated: image Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>
Closes #2096
Updating usage docs to the new templates
Changelog
New sections added
Updated sections