Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update carbon platform branch #3342

Conversation

francinelucca
Copy link
Collaborator

@francinelucca francinelucca commented Jan 10, 2023

Related #3339
Closes carbon-design-system/carbon-platform#1561

Changed

  • Merged with main

  • Resolved Merge Conflicts in the following files:

  • Tested all remote-mdx pages and work on carbon-platform new branch

Testing

In the carbon-platform project (https://github.com/carbon-design-system/carbon-platform), the branch flucca/test/pull-from-carbon-platform-branch has changes in place to:

pull @carbon/react assets from a test carbon.yml that is pointing to this (francinelucca:update-carbon-platform-branch) branch
points all remote pages to this (francinelucca:update-carbon-platform-branch) branch

  1. While in your local carbon-platform project, checkout to flucca/test/pull-from-carbon-platform-branch
  2. Run application and test some remote pages, should behave as expected in comparison to production (next.carbondesignsystem.com) , except for the changes outlined above.
  3. This should generate a bunch of new cached files since it's pulling from a different place. These can be discarded (if no new files are generated something went wrong).

laurenmrice and others added 30 commits August 16, 2022 14:26
* update: usage content

* update: usage images

* update: style content

* update: image

* update: image

* fix: run format

Co-authored-by: Josefina Mancilla <josefinanoemi4@gmail.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
…#3087)

* chore(deps): bump parse-url from 6.0.0 to 6.0.5

Bumps [parse-url](https://github.com/IonicaBizau/parse-url) from 6.0.0 to 6.0.5.
- [Release notes](https://github.com/IonicaBizau/parse-url/releases)
- [Commits](IonicaBizau/parse-url@6.0.0...6.0.5)

---
updated-dependencies:
- dependency-name: parse-url
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore(format):  run yarn format

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: TJ Egan <tw15egan@gmail.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
…ptions (carbon-design-system#3093)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* docs(date-picker): gower review

* Update date-format-placement.png

* add type styles

* Update style.mdx

* Apply suggestions from design review

Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>

* update calendar images

Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: jnm2377 <jnm2377@users.noreply.github.com>
Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* accessibility content for overflow menu

text and images for accessibility guidance

* fix: run format

Co-authored-by: Josefina Mancilla <32556167+jnm2377@users.noreply.github.com>
Co-authored-by: Josefina Mancilla <josefinanoemi4@gmail.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
…-system#3095)

* docs(migration): mention upgrade cli in developer docs

* Update develop.mdx

Co-authored-by: D.A. Kahn <40970507+dakahn@users.noreply.github.com>
* docs(tree-view): new component

* remove-tooltip-content

* Update usage.mdx

* formate updates

* Update usage.mdx

* add-style-tab-content

* remove line breaks

* fixed format bug

* fixed bugs

* image size test

* Update code.mdx

* update-images

* Update usage.mdx

* Apply suggestions from design review

Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>

* Update src/pages/components/tree-view/style.mdx

Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>

* updated-overview-image

* fix: format and add to nav

* Update code.mdx

Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Josefina Mancilla <josefinanoemi4@gmail.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* Update step-1.mdx

Hi,
it took me quiet some time to run the step-1 part of the tutorial, the section about icons namely.
After digging into documentation of `carbon-component-angular` module I was able to make the icons working properly.
Therefore you would like to propose couple changes in this part of the step-1 documentation.

* Update step-1.mdx

Forgot to mention the registration of the icon/s so adding that part as well.

* Update src/pages/developing/angular-tutorial/step-1.mdx

ok, thx

Co-authored-by: Akshat Patel <38994122+Akshat55@users.noreply.github.com>

* Update src/pages/developing/angular-tutorial/step-1.mdx

ok thx

Co-authored-by: Akshat Patel <38994122+Akshat55@users.noreply.github.com>

* Update src/pages/developing/angular-tutorial/step-1.mdx

ok thx

Co-authored-by: Akshat Patel <38994122+Akshat55@users.noreply.github.com>

Co-authored-by: Akshat Patel <38994122+Akshat55@users.noreply.github.com>
Co-authored-by: D.A. Kahn <40970507+dakahn@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
ibmButton attribute (directive) needs to value. According the page preview at the top I add `primary`.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
The --lint-fix parameter can't be used anymore for generating angular component.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* fix: remove ibm z pictograms

* chore: format
* feat(tutorial): add initial faqs

* docs(tutorial): add additional FAQ answers

Co-authored-by: TJ Egan <tw15egan@gmail.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* dividing file names for code snippets

There are 2 files (`src/app/home/home.module.ts` and `src/app/home/landing-page/landing-page.component.spec.ts`) mentioned above 2 code snippets that is explaining how to import carbon modules. But One code snippet is for app.module.ts and second is for landing-page.component.spec.ts and it unnecessary to mentioned both files above both code snippets.
This is on 2 spots `First row` and `Second row` section.

* division of file names above code snippets

Found addition 2 spots in `Repo page` section

Co-authored-by: D.A. Kahn <40970507+dakahn@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* Update overview.mdx

* chore(Overview): ran yarn:format
Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>
…arbon-design-system#3117)

* fix(2x-grid): fix link typo

* style(404): update 404 styles

* chore(format):  run yarn format

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* updating accessibility content and adding image

* Update accessibility.mdx

removed second image placeholder for now

* Update accessibility.mdx

rewrote introduction

* Update accessibility.mdx

rewrote heading

* Update accessibility.mdx

Reworded design guidance

* Update accessibility.mdx

updated link text

* Update accessibility.mdx

slight rewording

* added two images and updated content

* chore(loading): format PR

* Update loading-accessibility-3.png

added Lauren's image

Co-authored-by: dakahn <dakahn@protonmail.com>
* fix(docs): replace check emoji with CheckmarkOutline component

* fix(docs): remove unused import
* Update color-tokens.js

* run yarn format

* update-text-on-color-disabled

* add token name to values

* Update color-tokens.js

* remove token name in value

* update opacity formating

* reverting to previous format test

* reset formating again

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* [docs] text-input: usage-update

* added-rest-of-content

* content-QA

* update-img-link

* content-qa-2

* Apply suggestions from design review

Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>

* image and content updates

* Update usage.mdx

Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
* Notification for Tile

* Update src/pages/components/tile/usage.mdx

Co-authored-by: Anna Gonzales <agonz@us.ibm.com>

Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <anna.gonzales3@gmail.com>
Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>
Co-authored-by: Josefina Mancilla <32556167+jnm2377@users.noreply.github.com>
Co-authored-by: tay1orjones <tay1orjones@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
dependabot bot and others added 3 commits January 6, 2023 18:29
Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>
…arbon-platform

Co-authored-by: Andrea Cardona <Andrea.Cardona@ibm.com>
@vercel
Copy link

vercel bot commented Jan 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
carbondesignsystem ❌ Failed (Inspect) Jan 12, 2023 at 9:37PM (UTC)

@francinelucca francinelucca changed the base branch from main to carbon-platform January 10, 2023 21:51
francinelucca and others added 2 commits January 10, 2023 17:20
Co-authored-by: Andrea Cardona <Andrea.Cardona@ibm.com>
Co-authored-by: Andrea Cardona <Andrea.Cardona@ibm.com>
@francinelucca francinelucca marked this pull request as ready for review January 11, 2023 19:46
@francinelucca francinelucca requested review from a team as code owners January 11, 2023 19:46
@francinelucca francinelucca requested review from tw15egan, aledavila and laurenmrice and removed request for a team January 11, 2023 19:47
@francinelucca
Copy link
Collaborator Author

Note: it's ok for this branch not to build, some of the changes that we made make the code not actually be runnable (like removing imports) which is fine since we're just reading docs from this branch on platform.
We can ignore the failing Vercel deployment, this is not intended to ever be merged into main

@francinelucca
Copy link
Collaborator Author

FYI @mattrosno

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
laurenmrice and others added 2 commits January 12, 2023 20:18
* update .mdx

* update images

* fix merge conflict

* update a11y tab

* fix(tooltip): remove unused images

Co-authored-by: Taylor Jones <taylor.jones826@gmail.com>
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont have a local build to test, but I looked at the files changed and it seemed fine. Its a lot of stuff to check ....

@francinelucca francinelucca merged commit f3e1249 into carbon-design-system:carbon-platform Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.