Fluid pattern v2 #3382

aagonzales · 2023-02-08T20:09:22Z

New fluid pattern
https://carbondesignsystem-git-fork-aagonza-21ee91-carbon-design-system.vercel.app/patterns/fluid-styles/

Dev - How do I add this new page to the left nav? I always forget. And the name of the URL should now be fluid-styles but it hasn't seemed to update.

* Modal accessibility content and images * Update accessibility.mdx MIssed saving updates * Update accessibility.mdx updating bullets in dev section * Update accessibility.mdx updates to correct typos and and a subheading * Update accessibility.mdx Adjustments to dev considerations * Update to Do Don't pair * Update modal-accessibility-3.png added 2-button example * chore(format): fix format error * update images * Update src/pages/components/modal/accessibility.mdx Co-authored-by: Anna Gonzales <anna.gonzales3@gmail.com> * update images Co-authored-by: TJ Egan <tw15egan@gmail.com> Co-authored-by: Anna Gonzales <anna.gonzales3@gmail.com>

Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>

* typo fix unnecessary parenthesis * fix(form-patterns): ran yarn format (#3326) Co-authored-by: Scott Strubberg <sstrubberg@protonmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* typo fix There is an unnecessary period in the description under the default variant of data table. * fix: format Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* Update accessibility.mdx * added first images * Update accessibility.mdx removed flotsam from the copy and paste exercise * Update accessibility.mdx tweak spacing * Update accessibility.mdx * Update accessibility.mdx modifications for better readability * Update accessibility.mdx corrected link target * Update tooltip-accessibility-2.png * Update accessibility.mdx attempting to resolved error * Update accessibility.mdx * chore: format mdx Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* Update accessibility.mdx * added first images * Update accessibility.mdx removed flotsam from the copy and paste exercise * Update accessibility.mdx tweak spacing * Update accessibility.mdx * Update accessibility.mdx modifications for better readability * Update accessibility.mdx corrected link target * Update tooltip-accessibility-2.png * Update accessibility.mdx attempting to resolved error * Update accessibility.mdx * text and image changes for design annotations * chore(prettier): output of yarn:format * chore(prettier): output of yarn:format Co-authored-by: Taylor Jones <taylor.jones826@gmail.com>

* added fourth tab * Create accessibility.mdx First draft of accessibility tab content * Update accessibility.mdx updated content * Update accessibility.mdx remove space * Update accessibility.mdx * Update accessibility.mdx * images and accessibility content * updates update image; remove link to non-existing Design section * Update accessibility.mdx alter leading description and what carbon provides * Update accessibility.mdx add Oxford comma * Update accessibility.mdx updated alts for images * update images * chore(formatting): output of yarn format * Update accessibility.mdx Co-authored-by: Taylor Jones <taylor.jones826@gmail.com>

Co-authored-by: tw15egan <tw15egan@users.noreply.github.com>

Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* update .mdx * update images * fix merge conflict * update a11y tab * fix(tooltip): remove unused images Co-authored-by: Taylor Jones <taylor.jones826@gmail.com>

Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>

Co-authored-by: tay1orjones <tay1orjones@users.noreply.github.com>

The form patterns page currently uses an outdated link to the 2x grid page, resulting in a 404 not found. This patch updates the link to the correct route.

@laurenmrice

* Update accessibility.mdx * Update accessibility.mdx Added comboxbox info * added images * Update accessibility.mdx Updated content * Updated image and some text content * Update accessibility.mdx trying to fix final link * updated images replaced with @laurenmrice versions * Update accessibility.mdx removed blank line before closed caption tag to try to address text styling * Update accessibility.mdx Removing "press" from caption * Update src/pages/components/dropdown/accessibility.mdx Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com> * Update src/pages/components/dropdown/accessibility.mdx I altered a bit, but addressed Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com> * Update src/pages/components/dropdown/accessibility.mdx Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com> * Update accessibility.mdx fixed typo introduced by my inline edit Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>

@laurenmrice

* Update accessibility.mdx * added images * updated images replace with @laurenmrice versions * Update src/pages/components/select/accessibility.mdx Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com> * Update src/pages/components/select/accessibility.mdx Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com> Co-authored-by: TJ Egan <tw15egan@gmail.com> Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* Create sync-platform-branch * Update .github/workflows/sync-platform-branch * Update .github/workflows/sync-platform-branch * Update .github/workflows/sync-platform-branch Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>

* Update deploy.yml * chore: yarn format --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>

* update colors on Status indicators * update colors 2 * update green 40 * update icon colors * fix(color): update status-success to new values * update images from Jeannie --------- Co-authored-by: TJ Egan <tw15egan@gmail.com> Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com>

Co-authored-by: aledavila <aledavila@users.noreply.github.com>

Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>

* fix(react): replace codesandbox link with stackblitz * fix(mdxicon): reformat stackblitz icon --------- Co-authored-by: TJ Egan <tw15egan@gmail.com>

jeanservaas

Looks awesome, gave you just two typo updates offline and that's it!

francinelucca

LGTM! minor suggestions

src/pages/patterns/fluid-styles/index.mdx

francinelucca · 2023-02-14T21:46:58Z

Dev - How do I add this new page to the left nav? I always forget. And the name of the URL should now be fluid-styles but it hasn't seemed to update.

@aagonzales I see the page in the sidenav and url, do you still need dev help with this?

aagonzales · 2023-02-14T21:49:56Z

@francinelucca oh nice! I guess it just hadn't come through in the preview yet. That's all I needed was to confirm it was done right.

Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com>

francinelucca

🔥

mbgower and others added 30 commits December 20, 2022 18:24

Compressed Images (#3321)

add1f1f

Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>

Compressed Images (#3323)

2d503e0

Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>

typo fix (#3324)

c6dc314

* typo fix unnecessary parenthesis * fix(form-patterns): ran yarn format (#3326) Co-authored-by: Scott Strubberg <sstrubberg@protonmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

typo fix (#3325)

c4eea1d

* typo fix There is an unnecessary period in the description under the default variant of data table. * fix: format Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

update usage image (#3331)

5ca4ef4

chore(release): update carbon deps (#3335)

c5214a4

Co-authored-by: tw15egan <tw15egan@users.noreply.github.com>

Compressed Images (#3340)

2f02240

Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>

update .mdx (#3337)

df1b868

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

docs: tooltip a11y tab update (#3336)

feaee4e

* update .mdx * update images * fix merge conflict * update a11y tab * fix(tooltip): remove unused images Co-authored-by: Taylor Jones <taylor.jones826@gmail.com>

Compressed Images (#3349)

8b82fdb

Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>

updating the color tokens on the color page (#3345)

a6bdc38

chore(release): update carbon deps (#3350)

6864782

Co-authored-by: tay1orjones <tay1orjones@users.noreply.github.com>

chore(release): update carbon deps (#3355)

7a97c96

Co-authored-by: tay1orjones <tay1orjones@users.noreply.github.com>

Update link to 2x grid page (#3358)

451f151

The form patterns page currently uses an outdated link to the 2x grid page, resulting in a 404 not found. This patch updates the link to the correct route.

ci(deploy): remove ibm cloud deploy (#3367)

4202a4b

* Update deploy.yml * chore: yarn format --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

Compressed Images (#3371)

c04bb0a

Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>

Update .kodiak.toml (#3374)

91c7e63

chore(release): update carbon deps (#3372)

8294300

Co-authored-by: aledavila <aledavila@users.noreply.github.com>

Rename sync-platform-branch to sync-platform-branch.yml (#3376)

7f0d9ea

Compressed Images (#3378)

895acdb

Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>

fix(react): replace codesandbox link with stackblitz (#3369)

5891a37

* fix(react): replace codesandbox link with stackblitz * fix(mdxicon): reformat stackblitz icon --------- Co-authored-by: TJ Egan <tw15egan@gmail.com>

Update fluid-pattern-placement.png

d6ca537

aagonzales marked this pull request as ready for review February 14, 2023 20:46

aagonzales requested review from a team as code owners February 14, 2023 20:47

aagonzales requested review from tw15egan, francinelucca, thyhmdo, jeanservaas and aubrey-oneal and removed request for a team and thyhmdo February 14, 2023 20:47

aagonzales added status: ready for review 👀 and removed status: WIP 👩‍💻 DO NOT MERGE labels Feb 14, 2023

aagonzales added 2 commits February 14, 2023 14:49

updated-file-name

b576106

Update nav-items.yaml

6ed041e

vercel bot deployed to Preview February 14, 2023 21:07 View deployment

jeanservaas approved these changes Feb 14, 2023

View reviewed changes

fixed-typos

9e7efd7

francinelucca reviewed Feb 14, 2023

View reviewed changes

src/pages/patterns/fluid-styles/index.mdx Outdated Show resolved Hide resolved

src/pages/patterns/fluid-styles/index.mdx Outdated Show resolved Hide resolved

src/pages/patterns/fluid-styles/index.mdx Outdated Show resolved Hide resolved

vercel bot deployed to Preview February 14, 2023 21:51 View deployment

Apply suggestions from code review

794b2ab

Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com>

aagonzales requested a review from francinelucca February 14, 2023 21:52

vercel bot deployed to Preview February 14, 2023 22:05 View deployment

francinelucca approved these changes Feb 15, 2023

View reviewed changes

aagonzales merged commit abd09ef into carbon-design-system:fluid-inputs Feb 15, 2023

aagonzales linked an issue Feb 15, 2023 that may be closed by this pull request

Fluid inputs: Add pattern #3123

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fluid pattern v2 #3382

Fluid pattern v2 #3382

aagonzales commented Feb 8, 2023 •

edited

Loading

jeanservaas left a comment

francinelucca left a comment

francinelucca commented Feb 14, 2023

aagonzales commented Feb 14, 2023 •

edited

Loading

francinelucca left a comment

Fluid pattern v2 #3382

Fluid pattern v2 #3382

Conversation

aagonzales commented Feb 8, 2023 • edited Loading

jeanservaas left a comment

Choose a reason for hiding this comment

francinelucca left a comment

Choose a reason for hiding this comment

francinelucca commented Feb 14, 2023

aagonzales commented Feb 14, 2023 • edited Loading

francinelucca left a comment

Choose a reason for hiding this comment

aagonzales commented Feb 8, 2023 •

edited

Loading

aagonzales commented Feb 14, 2023 •

edited

Loading