Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: contained list demo code and usage tabs #3421

Merged
merged 6 commits into from
Mar 13, 2023
Merged

feat: contained list demo code and usage tabs #3421

merged 6 commits into from
Mar 13, 2023

Conversation

andreancardona
Copy link
Contributor

@andreancardona andreancardona commented Mar 7, 2023 •
edited
Loading

Closes #3152
Closes #3153

Testing:

  • Make sure Code tab for Contained list contains Component Demo with prop variants
  • Make sure Code tab for Contained list contains React Card under documentation
  • Make sure Usage tab for Contained list contains Component Demo with prop variants

@andreancardona andreancardona requested review from a team as code owners March 7, 2023 17:35
@vercel
Copy link

vercel bot commented Mar 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 13, 2023 at 9:45PM (UTC)

@andreancardona andreancardona mentioned this pull request Mar 7, 2023
Closed
francinelucca
francinelucca requested changes Mar 7, 2023
View reviewed changes
package.json Show resolved Hide resolved
src/data/docgen/react-docgen.json Outdated Show resolved Hide resolved
src/pages/components/contained-list/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/contained-list/usage.mdx Outdated Show resolved Hide resolved
andreancardona and others added 2 commits March 7, 2023 14:02
@andreancardona @francinelucca
Update src/pages/components/contained-list/usage.mdx
d30450e 
Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com>
@andreancardona
fix: variant clean up
cc8c33e
@andreancardona andreancardona mentioned this pull request Mar 8, 2023
Closed
laurenmrice
laurenmrice requested changes Mar 9, 2023
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreancardona

  • The demo on the tabs does not show the correct styling for Contained list. It is missing the divider lines and padding between list items. It should look more like the mock below.

Frame 2

  • The demo also does not respond when trying any of the controls in the panel.

@andreancardona
Copy link
Contributor Author

  • o also does not respond when trying any of the controls in th

I think you're running into the same caching issue that @francinelucca was running into. Let's look at it when we sync later :)

laurenmrice
laurenmrice approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! ✅

@andreancardona andreancardona enabled auto-merge (squash) March 13, 2023 21:22
@andreancardona andreancardona merged commit 73dec5b into carbon-design-system:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francinelucca francinelucca francinelucca approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

@aledavila aledavila Awaiting requested review from aledavila aledavila was automatically assigned from carbon-design-system/developers-system

@tw15egan tw15egan Awaiting requested review from tw15egan

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: live demo for contained list docs: code tab for contained list
4 participants
@andreancardona @tw15egan @francinelucca @laurenmrice