docs(typography): fix code type styles not using mono font #3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
francinelucca
approved these changes
Mar 10, 2023
thyhmdo
approved these changes
Mar 14, 2023
tay1orjones
approved these changes
Mar 15, 2023
tay1orjones
added
status: ready to merge 🎉
and removed
status: visual review 🔍
status: one more review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like there were still a few elements using
bxon the typography page which caused the code type styles to not IBM Plex Mono but IBM Plex Sans. Also, the styling on the right wasn't correct.In addition, I wrapped the right side in a
Layerso that the code snippet would render its background color correctly.Changelog
Changed
bxprefixes inTypesetExampletocds<Layer>to ensure code snippet receives correct background colorBefore
After
