Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(table): expansion and selection #3445

Merged
merged 7 commits into from
Mar 27, 2023
Merged

docs(table): expansion and selection #3445

merged 7 commits into from
Mar 27, 2023

Conversation

aagonzales
Copy link
Member

@aagonzales aagonzales commented Mar 21, 2023 •
edited
Loading

Closes #3437

  • Added documentation for the variant for "selectable + expandable" to usage and style tabs.
  • Added a variant section to help with information processing.
  • Reordered and clean-up some additional content
  • Updated some other table images as well.

@vercel
Copy link

vercel bot commented Mar 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 27, 2023 at 4:30PM (UTC)

@aagonzales aagonzales marked this pull request as ready for review March 23, 2023 15:26
@aagonzales aagonzales requested review from a team as code owners March 23, 2023 15:26
francinelucca
francinelucca requested changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! one minor detail

src/pages/components/data-table/usage.mdx Outdated Show resolved Hide resolved
laurenmrice
laurenmrice approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one punctuation comment. Everything else looks good to me ✅

aagonzales and others added 2 commits March 23, 2023 17:07
@aagonzales @laurenmrice
Update src/pages/components/data-table/usage.mdx
0369dcd 
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
@aagonzales @francinelucca
Update src/pages/components/data-table/usage.mdx
6e07766 
Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com>
@kodiakhq kodiakhq bot merged commit e2dd0b7 into carbon-design-system:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@francinelucca francinelucca francinelucca approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data table: Selectable & Expandable - Website docs
4 participants
@aagonzales @tay1orjones @francinelucca @laurenmrice