Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "expando" to "expand" #10317

Closed
6 tasks
Tracked by #9535
tay1orjones opened this issue Dec 19, 2021 · 0 comments · Fixed by #10357
Closed
6 tasks
Tracked by #9535

Rename "expando" to "expand" #10317

tay1orjones opened this issue Dec 19, 2021 · 0 comments · Fixed by #10357
Labels
package: react carbon-components-react role: dev 🤖

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Dec 19, 2021 •
edited
Loading

We want to use expand nomenclature instead of expando. This update will fall into one of a few categories:

  1. Prop name usage
    • In these cases, props should be renamed. Existing props deprecated.
  2. Internal component usages (functions, variables, etc)
    • If it's not in the public API, we can update it now without worry.
  3. Story, documentation, comment usages
    • These by and large should be updated now to use the new expand term. In cases of documentation relating to prop name usage, we can update to use the new expand* prop instead of the deprecated prop.

The following is a list of usages of expando in the codebase that need to be looked at (found via a find all search):

  • components/demo/js/data-table-demo-expand-all-manager.js
  • react/src/components/Accordion/AccordionItem.js
  • react/src/components/DataTable/TableExpandHeader.js
  • react/src/components/DataTable/stories/expansion/DataTable-expansion-story.js
  • react/src/components/TreeView/TreeNode.js
  • There do not appear to be any usages of expando on the website, but double check
@tay1orjones tay1orjones added role: dev 🤖 package: react carbon-components-react version: 11 Issues pertaining to Carbon v11 labels Dec 19, 2021
@tay1orjones tay1orjones added this to the v11 Release Candidate 0 milestone Dec 19, 2021
@tay1orjones tay1orjones mentioned this issue Dec 19, 2021
Closed
20 tasks
@tay1orjones tay1orjones changed the title Rename "expando" props to "expand" Rename "expando" to "expand" Dec 19, 2021
@tay1orjones tay1orjones removed this from the v11 Release Candidate 0 milestone Dec 19, 2021
@tay1orjones tay1orjones removed the version: 11 Issues pertaining to Carbon v11 label Dec 19, 2021
@joshblack joshblack mentioned this issue Jan 4, 2022
Closed
46 tasks
@sstrubberg sstrubberg mentioned this issue Jan 7, 2022
Merged
@jnm2377 jnm2377 mentioned this issue Mar 30, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package: react carbon-components-react role: dev 🤖
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(react): deprecate renderExpando and add renderToggle sstrubberg/carbon
1 participant
@tay1orjones