Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(React): remove deprecated v11 props #11104

Merged
merged 11 commits into from
Mar 31, 2022
Merged

fix(React): remove deprecated v11 props #11104

merged 11 commits into from
Mar 31, 2022

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Mar 29, 2022 •
edited by joshblack
Loading

Closes #11082

Remove deprecated in v11 props from the following files:

partially closes #8418

  • Accordion/Accordion.Skeleton.js
  • Accordion/AccordionItem.js
  • Button/Button.js
  • Checkbox/Checkbox.js
  • ContentSwitcher/ContentSwitcher.js
  • DataTable/Table.js
  • DataTable/TableExpandHeader.js
  • DataTable/TableToolbarSearch.js
  • DatePickerInput/DatePickerInput.js
  • DatePickerInput/next/DatePickerInput.js
  • Dropdown/Dropdown.js
  • Dropdown/Dropdown.Skeleton.js
  • InlineLoading/InlineLoading.js
  • Modal/Modal.js
  • Modal/next/Modal.js

@dakahn dakahn requested review from a team as code owners March 29, 2022 21:56
@dakahn
Copy link
Contributor Author

dakahn commented Mar 29, 2022

Didn't touch datepickerinput and modal (designated that above) because as per the instructions they had corresponding /next files 👍🏾

@netlify
Copy link

netlify bot commented Mar 29, 2022 •
edited
Loading

✅ Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 00f312f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6245b7e9a223c70009b07a61
😎 Deploy Preview https://deploy-preview-11104--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

joshblack
joshblack approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just left a refactor note

packages/react/src/components/DatePickerInput/next/DatePickerInput.js Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Mar 29, 2022 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 00f312f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6245b7e9f9d880000878b5a9
😎 Deploy Preview https://deploy-preview-11104--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@joshblack
Copy link
Contributor

@dakahn @tay1orjones one thing I noticed is that the VRT for button changed. Is this the correct change for the size prop updates?

@tay1orjones
Copy link
Member

tay1orjones commented Mar 30, 2022 •
edited
Loading

@joshblack @dakahn my guess is that the vrt test needs to be updated to use the correct/new size prop values. We should be careful and double check them. It certainly feels odd that a size of lg uses a classname with xl in it.

@sstrubberg did you run into problems with button sizes when doing #10532 ?

@joshblack joshblack merged commit caf3cf1 into carbon-design-system:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm2377 jnm2377 jnm2377 left review comments

@tay1orjones tay1orjones tay1orjones approved these changes

@joshblack joshblack joshblack approved these changes

@sstrubberg sstrubberg Awaiting requested review from sstrubberg

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: incorrect prop types provided by getToolbarProps for v11 Remove deprecated code from React package
4 participants
@dakahn @joshblack @tay1orjones @jnm2377