Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: incorrect prop types provided by getToolbarProps for v11 #11082

Closed
2 tasks done
tkolanko opened this issue Mar 28, 2022 · 0 comments · Fixed by #11104
Closed
2 tasks done

[Bug]: incorrect prop types provided by getToolbarProps for v11 #11082

tkolanko opened this issue Mar 28, 2022 · 0 comments · Fixed by #11104
Assignees

Comments

@tkolanko
Copy link

Package

@carbon/react

Browser

Chrome

Package version

0.17.0

React version

17.0.2

Description

The render function getToolbarProps() from DataTable is providing incorrect prop types for v11. The function is defined at
https://github.com/carbon-design-system/carbon/blob/main/packages/react/src/components/DataTable/DataTable.js#L385 and is returning a size of small but for v11 the prop is expecting sm https://github.com/carbon-design-system/carbon/blob/main/packages/react/src/components/DataTable/TableToolbar.js#L43

CodeSandbox example

n/a

Steps to reproduce

Use a datatable with a toolbar

Code of Conduct

@tkolanko tkolanko changed the title [Bug]: [Bug]: incorrect prop types provided by getToolbarProps for v11 Mar 28, 2022
@joshblack joshblack added package: react carbon-components-react version: 11 Issues pertaining to Carbon v11 package: @carbon/react @carbon/react component: data-table and removed status: needs triage 🕵️‍♀️ package: react carbon-components-react labels Mar 31, 2022
@joshblack joshblack self-assigned this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants