Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Number input] control update #5417

Closed
aagonzales opened this issue Feb 21, 2020 · 10 comments · Fixed by #7687
Closed

[Number input] control update #5417

aagonzales opened this issue Feb 21, 2020 · 10 comments · Fixed by #7687

Comments

@aagonzales
Copy link
Member

aagonzales commented Feb 21, 2020

Original prompt:
Explore other control options besides the up/down carets.
image


Final decision:
#5417 (comment)

@laurenmrice
Copy link
Member

thoughts?
Screen Shot 2020-03-09 at 11 40 45 AM

@laurenmrice
Copy link
Member

Also ones still using carets:
Screen Shot 2020-03-09 at 11 41 37 AM

@aagonzales
Copy link
Member Author

I like A B C

  • I think the + and - read better than the chevron icons which are normally used for opening/closing things.
  • I can't actually decided between A and C if the full lines or half line is better.
  • I like B because it seems like a more natural order for the control.

@laurenmrice
Copy link
Member

laurenmrice commented Mar 9, 2020

Yeah the chevron one could be confusing. I think B is nice visually. But now wondering where error state icon would go. could work better for A or C.
sm-320px-4 column

@tw15egan
Copy link
Member

tw15egan commented Mar 9, 2020

Would this just make the mobile version the default? It would be a pretty easy change if we decide to go to B (would just need to change the icons and extend the border, possibly other things my dev eyes are missing)

Current mobile version:
Screen Shot 2020-03-09 at 1 33 30 PM

@laurenmrice
Copy link
Member

laurenmrice commented Mar 9, 2020

Yeah I was wondering about that too. ^^ I notice the mobile version also does not include the invalid icon. Wasn't sure where to put that other than outside of the field. Looked wonky inside or attached on the outside.

@tw15egan
Copy link
Member

tw15egan commented Mar 9, 2020

Yeah I agree, we could always render the error icon next to the error text 🤷‍♂

@laurenmrice
Copy link
Member

laurenmrice commented Mar 10, 2020

Screen Shot 2020-03-10 at 10 32 48 AM

The input alignment could get weird with B if in a form if we want it to have some sort of text alignment. We would prob have to center the input text, and even if we left aligned it, it would never really align with anything because there is a button on the left.

Kind of thinking C is the best option with full rule lines and is less fussy than A with the shorter rules. (however i know the fluid inputs have a smaller rule because the label is in the field)


Also this is Petes mobile number input for reference:
Screen Shot 2020-03-10 at 11 09 17 AM

@tw15egan
Copy link
Member

Makes sense to me 👍

@laurenmrice
Copy link
Member

Final design

Number input (fixed) - White theme.png


Final spec

Number input (fixed) — Specs.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants