Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show more button does not appear when code snippet is put in a tab #5819

Closed
2 tasks done
Donisius opened this issue Apr 7, 2020 · 1 comment · Fixed by #5854
Closed
2 tasks done

Show more button does not appear when code snippet is put in a tab #5819

Donisius opened this issue Apr 7, 2020 · 1 comment · Fixed by #5854
Labels
component: code-snippet status: needs more info type: bug 🐛

Comments

@Donisius
Copy link

Donisius commented Apr 7, 2020 •
edited
Loading

What package(s) are you using?

    "carbon-components": "10.9.3",
    "carbon-components-react": "7.9.3",
  • carbon-components
  • carbon-components-react

Detailed description

Describe in detail the issue you're having.

If you put a code snippet in the very first tab that is opened with overflow content, the show more button appears, putting the code snippet in other tabs prevents the button from appearing.

Is this issue related to a specific component?

Code snippet and tabs

What did you expect to happen? What happened instead? What would you like to
see changed?

Show more button should appear.

What browser are you working in?

Chrome

What version of the Carbon Design System are you using?

10.9.3
@emyarod
Copy link
Member

emyarod commented Apr 7, 2020

can you create a reduced test case in Code Sandbox for easier testing and debugging?

asudoh added a commit to asudoh/carbon-components that referenced this issue Apr 14, 2020
@asudoh
fix(CodeSnippet): observe resize
04a306d 
This change makes `<CodeSnippet>` observes for the resize of its
top-level element so the visibility of Show More button can be updated
upon the up-to-date element size.

Fixes carbon-design-system#5819.
This was referenced Apr 14, 2020
Merged
Closed
tw15egan added a commit that referenced this issue Apr 20, 2020
@asudoh @tw15egan
fix(CodeSnippet): observe resize (#5854)
f18dedd 
This change makes `<CodeSnippet>` observes for the resize of its
top-level element so the visibility of Show More button can be updated
upon the up-to-date element size.

Fixes #5819.

Co-authored-by: TJ Egan <tw15egan@gmail.com>
joshblack pushed a commit to joshblack/carbon that referenced this issue Apr 23, 2020
@asudoh @tw15egan @joshblack
fix(CodeSnippet): observe resize (carbon-design-system#5854)
3689576 
This change makes `<CodeSnippet>` observes for the resize of its
top-level element so the visibility of Show More button can be updated
upon the up-to-date element size.

Fixes carbon-design-system#5819.

Co-authored-by: TJ Egan <tw15egan@gmail.com>
joshblack pushed a commit to joshblack/carbon that referenced this issue Apr 23, 2020
@asudoh @tw15egan @joshblack
fix(CodeSnippet): observe resize (carbon-design-system#5854)
3c72a50 
This change makes `<CodeSnippet>` observes for the resize of its
top-level element so the visibility of Show More button can be updated
upon the up-to-date element size.

Fixes carbon-design-system#5819.

Co-authored-by: TJ Egan <tw15egan@gmail.com>
joshblack pushed a commit that referenced this issue Apr 23, 2020
@asudoh @tw15egan @joshblack
fix(CodeSnippet): observe resize (#5854)
94ca4e1 
This change makes `<CodeSnippet>` observes for the resize of its
top-level element so the visibility of Show More button can be updated
upon the up-to-date element size.

Fixes #5819.

Co-authored-by: TJ Egan <tw15egan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: code-snippet status: needs more info type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(CodeSnippet): observe resize asudoh/carbon-components
3 participants
@asudoh @emyarod @Donisius