Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primary button inner border has wrong color in dark themes #6636

Closed
emyarod opened this issue Aug 7, 2020 · 2 comments
Closed

Primary button inner border has wrong color in dark themes #6636

emyarod opened this issue Aug 7, 2020 · 2 comments
Labels
component: button type: bug 🐛

Comments

@emyarod
Copy link
Member

emyarod commented Aug 7, 2020

originally reported by @laurenmrice

image
@emyarod emyarod self-assigned this Aug 7, 2020
@laurenmrice
Copy link
Member

laurenmrice commented Aug 26, 2020 •
edited
Loading

For example: The transparent inset space on focus will show the background color the button sits on.
Screen Shot 2020-08-26 at 2 06 41 PM

@emyarod emyarod removed their assignment Jan 11, 2021
@joshblack joshblack mentioned this issue Feb 8, 2021
Closed
62 tasks
@tw15egan
Copy link
Member

tw15egan commented Feb 8, 2021

I believe this is working as expected, we recently changed it to ui-background because transparent would cause the background to extend #7025 (comment), not actually be transparent due to the nature of the box shadow. It is currently set to ui-background in all themes and was bundled in this PR: #7029

Going to close this as resolved and based on @laurenmrice's feedback in #7029, but let me know if there are any other issues with Button 👍

@tw15egan tw15egan closed this as completed Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: button type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emyarod @tw15egan @laurenmrice