style(button): fix various button bugs #7029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw15egan
force-pushed
the
button-fixes
branch
from
7a794c4
to
ec74c9f
Compare
|
Deploy preview for carbon-elements ready! Built with commit 7a794c4 |
|
Deploy preview for carbon-components-react ready! Built with commit 7a794c4 https://deploy-preview-7029--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit 479d473 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 479d473 https://deploy-preview-7029--carbon-components-react.netlify.app |
laurenmrice
approved these changes
Oct 13, 2020
dakahn
approved these changes
Oct 14, 2020
tw15egan
force-pushed
the
button-fixes
branch
from
5bacdf4
to
832ee56
Compare
|
Is this ready to be merged @tw15egan ? |
|
bump @joshblack |
joshblack
approved these changes
Oct 20, 2020
This was referenced Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7021
Closes #7025
Closes #7026
Various bug fixes for style issues found in
Button.Changelog
New
Dangervariant to Playground:activestyles forTertiary Button([button] tertiary button has active state bug in Chrome browser #7026)disabledclass is present ([button] disabled states have bugs #7021)Changed
ButtonSetstyles to after the@include button-base;mixin call that is applied tobx--btn. This was causing styling issues as things were not properly cascading down. ([button] disabled states have bugs #7021)$disabledtokens with$disabled-03([button] disabled states have bugs #7021)$ui-02to$ui-background([button] inset focus needs to be transparent #7025)Removed
disabledstyle block that was causing wrong values to be usedTesting / Reviewing
disabledknob and ensuredisabledstyles are correct across all variants