Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data table V2: Canceling batch action doesn't remove selected class from rows #675

Closed
faulke opened this issue Mar 26, 2018 · 2 comments
Closed
Assignees

Comments

@faulke
Copy link

faulke commented Mar 26, 2018

Detailed description

When a batch action is canceled, all rows are deselected, but the selected class (e.g., bx--data-table-v2--selected) remains on all tr elements that were previously selected.

Is this issue related to a specific component?
Data table V2

What did you expect to happen? What happened instead?
Expected:

Rows are deselected and selected class is removed from all rows.

Actual:

Rows are deselected, but the selected class remains on all rows that were previously selected.

What browser are you working in?
Chrome 65.0.3325.181

What version of the Carbon Design System are you using?
v8.10.0

Steps to reproduce the issue

  1. Select the checkbox for a table row.
  2. Click the Cancel button in the table toolbar next to # items Selected.

Additional information

gcj9tmjtkb

@joshblack
Copy link
Contributor

joshblack commented May 18, 2018

Hi @faulke! 👋 Thanks so much for taking the time to make this issue. cc'ing @asudoh in case he has any thoughts on this.

@alisonjoseph
Copy link
Member

@joshblack can we not just loop through the selected classes and remove them when clicking the cancel button?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants