Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook emits prop type warning for tertiary and ghost danger buttons #7211

Closed
emyarod opened this issue Nov 3, 2020 · 0 comments · Fixed by #7212
Closed

Storybook emits prop type warning for tertiary and ghost danger buttons #7211

emyarod opened this issue Nov 3, 2020 · 0 comments · Fixed by #7212
Assignees
@emyarod
Labels
type: bug 🐛 type: docs 📖

Comments

@emyarod
Copy link
Member

emyarod commented Nov 3, 2020 •
edited
Loading

Detailed description

Related #7087

Describe in detail the issue you're having.

When running storybook in dev mode, storybook emits warnings for invalid prop types in the ghost danger button:

Warning: Failed prop type: Invalid prop `kind` of value `danger-ghost` supplied to `Button`, expected one of ["primary","secondary","danger","ghost","danger--primary","danger--tertiary","danger-tertiary","tertiary"].
    in Button

Additional information

image
@emyarod emyarod self-assigned this Nov 3, 2020
@emyarod emyarod changed the title Storybook emits prop type warning for tertiary danger buttons Storybook emits prop type warning for tertiary and ghost danger buttons Nov 3, 2020
@emyarod emyarod mentioned this issue Nov 3, 2020
Merged
@kodiakhq kodiakhq bot closed this as completed in #7212 Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emyarod emyarod

Labels
type: bug 🐛 type: docs 📖
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(button): update button kind prop type emyarod/carbon
1 participant
@emyarod