fix(button): update button kind prop type #7212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 1e828c1 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 1e828c1 https://deploy-preview-7212--carbon-components-react.netlify.app |
tw15egan
approved these changes
Nov 4, 2020
emyarod
deleted the
7211-remove-tertiary-danger-button-proptype-warnings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7211
This PR adds the ghost danger button to the list of accepted button kind prop types and updates the danger button variant class modifiers to use the double dash naming convention
Changelog
New
Changed
Testing / Reviewing
View storybook in dev mode and confirm there are no prop type warnings