Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Existing Sketch plugin icons are not modified when sync command is run #7614

Closed
emyarod opened this issue Jan 20, 2021 · 0 comments · Fixed by #7648
Closed

Regression: Existing Sketch plugin icons are not modified when sync command is run #7614

emyarod opened this issue Jan 20, 2021 · 0 comments · Fixed by #7648
Assignees
@emyarod @andreancardona
Labels
type: bug 🐛

Comments

@emyarod
Copy link
Member

emyarod commented Jan 20, 2021

related #5758
related #5711

When running the icons sync command in the Sketch plugin, the existing artboards and symbols are not modified and the updated artwork is placed on new artboards instead. This is likely due to (breaking) name changes which were laying the groundwork for icon and pictogram plans for the plugin, but these plans may have shifted. We will need to confirm whether or not these plans are still on, and if not, we will investigate further into whether or not rolling back the name changes is a valid resolution for this issue. Resolving this issue will lead into resolving further issues detailed in #5749 and #6485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emyarod emyarod

@andreancardona andreancardona

Labels
type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sketch): match symbol names to existing format emyarod/carbon
2 participants
@emyarod @andreancardona