Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] sketch plugin has bug issues #6485

Closed
4 tasks done
laurenmrice opened this issue Jul 16, 2020 · 2 comments
Closed
4 tasks done

[icons] sketch plugin has bug issues #6485

laurenmrice opened this issue Jul 16, 2020 · 2 comments
Assignees
Labels
epic Special label used by ZenHub for epic functionality package: sketch @carbon/sketch type: bug 🐛

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Jul 16, 2020

  • While doing a test with the latest sketch plugin I noticed that some icons are rendering incorrectly by skewing their proportions.

  • We originally thought that this was only happening to icons that did not have a transparent rectangle layer applied to them in their svgs, but that is not the case. This is also happening to icons that do have the transparent rectangle.

  • I made an audit here of the icons this is happening to for each size and if there is a transparent rectangle or not. I also addressed when they are being put into a new file vs rendered onto an existing id.

https://www.notion.so/carbondesignsystem/Rendering-problems-c85a5d53e45b4716b6b1bb6a1776c4ea


In addition to the rendering issues the following problems are also happening:

@joshblack joshblack added the package: sketch @carbon/sketch label Jul 16, 2020
@emyarod emyarod added the epic Special label used by ZenHub for epic functionality label Sep 24, 2020
@emyarod
Copy link
Member

emyarod commented Jan 28, 2021

after #7648 it seems that new icons are being added on sync, WIP still under way on the sync itself skewing icons as well as removing deprecated icon symbols and artboards

@emyarod
Copy link
Member

emyarod commented Mar 19, 2021

resolved by #5597 #5749 #5758 #7711 #7712 #8060

@emyarod emyarod closed this as completed Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Special label used by ZenHub for epic functionality package: sketch @carbon/sketch type: bug 🐛
Projects
None yet
Development

No branches or pull requests

5 participants