Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(Tag): add RTL testing for Tag #10375

Merged
merged 12 commits into from
Jan 13, 2022
Merged

test(Tag): add RTL testing for Tag #10375

merged 12 commits into from
Jan 13, 2022

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Jan 11, 2022

Closes #10274

Adds RTL testing for Tag component.

@dakahn dakahn requested a review from a team as a code owner January 11, 2022 01:21
@netlify
Copy link

netlify bot commented Jan 11, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 9de7c0d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61e0acb08e02fc0008e06b7e

😎 Browse the preview: https://deploy-preview-10375--carbon-react-next.netlify.app

@dakahn
Copy link
Contributor Author

dakahn commented Jan 11, 2022

Theres a few eslint errors angry at how im testing. Looking for suggestions on the proper way 🏄🏾

@netlify
Copy link

netlify bot commented Jan 11, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: d7758ba

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61dcdbaa2760d4000808440d

😎 Browse the preview: https://deploy-preview-10375--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 11, 2022

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: d7758ba

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61dcdbaa2946fc0007b2959b

😎 Browse the preview: https://deploy-preview-10375--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jan 11, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 9de7c0d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61e0acb044d8900008c18937

😎 Browse the preview: https://deploy-preview-10375--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 11, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 9de7c0d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61e0acb04ba1580007bf4a53

😎 Browse the preview: https://deploy-preview-10375--carbon-components-react.netlify.app

joshblack
joshblack suggested changes Jan 12, 2022
View reviewed changes
packages/react/src/components/Tag/Tag-test.js Outdated Show resolved Hide resolved
packages/react/src/components/Tag/Tag-test.js Outdated Show resolved Hide resolved
packages/react/src/components/Tag/Tag-test.js Outdated Show resolved Hide resolved
packages/react/src/components/Tag/Tag-test.js Show resolved Hide resolved
@dakahn
Copy link
Contributor Author

dakahn commented Jan 12, 2022

Bringing in that icon for the last test is giving me a strange "circular reference" error
image
🤔

@dakahn dakahn requested a review from joshblack January 13, 2022 21:36
@kodiakhq kodiakhq bot merged commit 26c0610 into carbon-design-system:main Jan 13, 2022
kennylam added a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
@kennylam
chore(deps): update linting packages (carbon-design-system#11248)
ba8b555 
### Related Ticket(s)

Closes carbon-design-system#10375

### Description

This removes local linting packages in favor of hosted ones.

### Changelog

**New**

- add `eslint-config-carbon` and `stylelint-config-carbon` linting packages

**Changed**

- update styles to use CSS logical properties
- update lint configs
- `packages/storybook-images` folder moved to `packages/web-components/.storybook/`
- various configs moved to package.json and standalone files removed

**Removed**
- local lint packages removed
  - `eslint-config-ibmdotcom`
  - `eslint-plugin-ibmdotcom-import-rules`
  - `eslint-plugin-react-prop-type-comments`
  - `stylelint-config-ibmdotcom`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use RTL for testing in Tag/Tag-test.js
3 participants
@dakahn @joshblack @abbeyhrt