Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UIShell): change div to ul #10516

Merged
merged 3 commits into from
Jan 26, 2022
Merged

fix(UIShell): change div to ul #10516

merged 3 commits into from
Jan 26, 2022

Conversation

tw15egan
Copy link
Member

Closes #10515

Changes the element from a div to a ul, since it contains a list of li

Changelog

Changed

  • div changed to ul in UIShell/HeaderSideNavItems

Testing / Reviewing

Ensure it renders as expected and no new a11y violations are thrown

@tw15egan tw15egan requested a review from a team as a code owner January 25, 2022 14:29
@netlify
Copy link

netlify bot commented Jan 25, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 4b63c3f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61f1a9ce0bf8870008c47941

😎 Browse the preview: https://deploy-preview-10516--carbon-react-next.netlify.app

@alisonjoseph alisonjoseph mentioned this pull request Jan 25, 2022
Closed
21 tasks
@netlify
Copy link

netlify bot commented Jan 25, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 4b63c3f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f1a9ce1ac414000862c77a

😎 Browse the preview: https://deploy-preview-10516--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 25, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 4b63c3f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f1a9ce05a0c1000821f2b1

😎 Browse the preview: https://deploy-preview-10516--carbon-components-react.netlify.app

@kodiakhq kodiakhq bot merged commit e11bf01 into carbon-design-system:main Jan 26, 2022
@tw15egan tw15egan deleted the ui-shell-a11y branch March 3, 2022 16:14
kennylam pushed a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
@IgnacioBecerra @kodiakhq
feat(data-table): sync with @carbon/react v11 (carbon-design-system#1…
7041b19 
…0516)

* feat(data-table): sync with v11

* fix(data-table): fix to compile

* fix(table): more compile error fix

* fix(data-table): address some comments

* fix(data-table): sizes, checkbox, skeleton

* chore(data-table): restructuring story directory

* fix(data-table): overflow hover on menu

* fix(data-table): updated docs

* feat(data-table): dispatching elements

* fix(data-table): single story folder and example update

* fix(data-table): cleanup

* fix(data-table): addressed comments

* fix(data-table): addressed comments

* fix(data-table): addressed final comments

* fix(data-table): refactored styles for attribute within host

* fix(data-table): emit tokens

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@aledavila aledavila aledavila approved these changes

@abbeyhrt abbeyhrt Awaiting requested review from abbeyhrt abbeyhrt was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[a11y]: HeaderSideNavItems should use a ul rather than div
3 participants
@tw15egan @joshblack @aledavila