Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grid): add span support to Column and grid package #10538

Merged

Conversation

joshblack
Copy link
Contributor

Closes #10473

This PR adds a snippet to our migration guide for the changes coming to Grid. It also adds in support for start, end to our grid package and Column component. It documents this behavior in the Grid Start End story in storybook.

Changelog

New

  • Add col-end-{i} support to the grid package

Changed

  • Update col-start-{i} to iterate through all grid lines (number of columns + 1)
  • Update Column to support start, end in breakpoint props
  • Update tests for Column to test for combinations

Removed

Testing / Reviewing

  • Review migration material and verify its accuracy
  • View the "Grid Start End" story and verify the offsets work correctly
  • Make sure changes have corresponding tests

@joshblack joshblack requested a review from a team as a code owner January 26, 2022 22:36
@netlify
Copy link

netlify bot commented Jan 26, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: fd63081

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61f337206d222d0008d61db8

😎 Browse the preview: https://deploy-preview-10538--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jan 26, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 19c51a1

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f1ccf8762da40007e3ef54

😎 Browse the preview: https://deploy-preview-10538--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 26, 2022

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 19c51a1

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f1ccf8762da40007e3ef56

😎 Browse the preview: https://deploy-preview-10538--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jan 26, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: fd63081

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f33720d98c1f000780e300

😎 Browse the preview: https://deploy-preview-10538--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 26, 2022

❌ Deploy Preview for carbon-components-react failed.

🔨 Explore the source changes: de1cad7

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f1cd02e3427a0008f0fe57

@netlify
Copy link

netlify bot commented Jan 26, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: fd63081

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f3372098b69e00077f6e95

😎 Browse the preview: https://deploy-preview-10538--carbon-components-react.netlify.app/

Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine 👍🏾

docs/migration/v11.md Outdated Show resolved Hide resolved
docs/migration/v11.md Outdated Show resolved Hide resolved
Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two very small typos!

@kodiakhq kodiakhq bot merged commit de76f3a into carbon-design-system:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit how we're doing "column span" props to make sure they make sense in CSS Grid
3 participants