-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grid): add span support to Column and grid package #10538
feat(grid): add span support to Column and grid package #10538
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: fd63081 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61f337206d222d0008d61db8 😎 Browse the preview: https://deploy-preview-10538--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 19c51a1 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f1ccf8762da40007e3ef54 😎 Browse the preview: https://deploy-preview-10538--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 19c51a1 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f1ccf8762da40007e3ef56 😎 Browse the preview: https://deploy-preview-10538--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: fd63081 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f33720d98c1f000780e300 😎 Browse the preview: https://deploy-preview-10538--carbon-elements.netlify.app |
❌ Deploy Preview for carbon-components-react failed. 🔨 Explore the source changes: de1cad7 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f1cd02e3427a0008f0fe57 |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: fd63081 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f3372098b69e00077f6e95 😎 Browse the preview: https://deploy-preview-10538--carbon-components-react.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on my machine 👍🏾
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two very small typos!
Co-authored-by: Abbey Hart <abbeyhrt@gmail.com>
Co-authored-by: Abbey Hart <abbeyhrt@gmail.com>
Closes #10473
This PR adds a snippet to our migration guide for the changes coming to Grid. It also adds in support for
start
,end
to our grid package andColumn
component. It documents this behavior in theGrid Start End
story in storybook.Changelog
New
col-end-{i}
support to the grid packageChanged
col-start-{i}
to iterate through all grid lines (number of columns + 1)Column
to supportstart
,end
in breakpoint propsRemoved
Testing / Reviewing