Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TimePicker): update light propType for storybook table #10945

Merged
merged 3 commits into from
Mar 11, 2022

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Mar 9, 2022

Closes #10598

Audit: #10598 (comment)

Changelog

  • updates the light propType info so the storybook props table is populated correctly (in case people don't click on the custom button)

  • as is:

Screen Shot 2022-03-09 at 12 12 49 PM

  • to be:

Screen Shot 2022-03-09 at 12 13 10 PM

Testing / Reviewing

  • Ensure storybook v11 props table for TimePicker is updated correctly and all tests pass.

@jnm2377 jnm2377 requested a review from a team as a code owner March 9, 2022 18:15
@jnm2377 jnm2377 requested review from abbeyhrt and dakahn March 9, 2022 18:15
@netlify
Copy link

netlify bot commented Mar 9, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 725a52f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/622b74db96d0fd00092de5af

😎 Browse the preview: https://deploy-preview-10945--carbon-react-next.netlify.app

@jnm2377 jnm2377 mentioned this pull request Mar 9, 2022
31 tasks
@netlify
Copy link

netlify bot commented Mar 9, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 77fea75

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6228eec021861300089b5084

😎 Browse the preview: https://deploy-preview-10945--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 9, 2022

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 77fea75

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6228eec07f01580008cd2181

😎 Browse the preview: https://deploy-preview-10945--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Mar 9, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 725a52f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/622b74db1cd14d00089f019e

😎 Browse the preview: https://deploy-preview-10945--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 9, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 725a52f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/622b74db44536300089a31d1

😎 Browse the preview: https://deploy-preview-10945--carbon-components-react.netlify.app

@kodiakhq kodiakhq bot merged commit 0f9351b into carbon-design-system:main Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimePicker: v11 audit
3 participants