Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(popover): update popover usage and implementation #10952

Merged
merged 4 commits into from
Mar 15, 2022
Merged

refactor(popover): update popover usage and implementation #10952

merged 4 commits into from
Mar 15, 2022

Conversation

joshblack
Copy link
Contributor

Reference: #10426

Changelog

New

Changed

  • Update type tokens in popover story to use: $heading-compact-01 and $body-compact-01`

Removed

  • The light prop and style are no longer applied to Popover

Testing / Reviewing

  • Go through usage docs and verify that their accurate and cover common component use-cases, including
    • How to open and close the component
    • How to configure the appearance of the component
    • How to configure the alignment of the popover relative to the trigger

@joshblack joshblack requested a review from a team as a code owner March 10, 2022 16:55
@netlify
Copy link

netlify bot commented Mar 10, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: ac77ac8

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6230eaa76465400008ec2260

😎 Browse the preview: https://deploy-preview-10952--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Mar 10, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: ac77ac8

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6230eaa707bb91000816ed6c

😎 Browse the preview: https://deploy-preview-10952--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Mar 10, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: ac77ac8

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6230eaa7a9485a000825b1d1

😎 Browse the preview: https://deploy-preview-10952--carbon-elements.netlify.app

@joshblack joshblack requested a review from a team as a code owner March 11, 2022 18:24
@tay1orjones tay1orjones requested a review from dakahn March 11, 2022 22:07
laurenmrice
laurenmrice approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@kodiakhq kodiakhq bot merged commit 6a345aa into carbon-design-system:main Mar 15, 2022
kennylam added a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
@jkaeser @proeung
@kennylam @ibmdotcom-bot @andy-blum @ariellalgilmore @renovate @emyarod @kodiakhq @annawen1 @IgnacioBecerra @sanjitbauli @mattrosno @renovate-bot @jeffchew @abdonrd @github-actions @dependabot @tweenn @oliviaflory @m4olivei @pjudge
feat(masthead-v2): integrate alpha branch (carbon-design-system#10952)
b7cc871 
* feat(masthead-v2): integrate alpha branch

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Putra Bonaccorsi <putra.roeung@gmail.com>
Co-authored-by: Kenny Lam <kennylam@protonmail.com>
Co-authored-by: ibmdotcom-bot <digdes@us.ibm.com>
Co-authored-by: Andy Blum <andy.blum.01@gmail.com>
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: andrew <emyarod@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: Anna Wen <54281166+annawen1@users.noreply.github.com>
Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu>
Co-authored-by: Carbon for IBM.com Bot <53266321+ibmdotcom-bot@users.noreply.github.com>
Co-authored-by: sanjitbauli <sanjitbauli@in.ibm.com>
Co-authored-by: Matt Rosno <matt.rosno@ibm.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Jeff Chew <jeff.chew@gmail.com>
Co-authored-by: Abdón Rodríguez Davila <a@abdonrd.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kennylam <kennylam@proton.me>
Co-authored-by: Felipe Zuntini <1704162+tweenn@users.noreply.github.com>
Co-authored-by: Olivia Flory <45692622+oliviaflory@users.noreply.github.com>
Co-authored-by: Matthew Oliveira <m4olivei@gmail.com>
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
Co-authored-by: Pauline <paulinemjudge@gmail.com>
Co-authored-by: Pauline <pauline.judge@lullabot.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@dakahn dakahn dakahn approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

@tw15egan tw15egan Awaiting requested review from tw15egan tw15egan was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joshblack @tay1orjones @dakahn @laurenmrice @jnm2377