Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(TreeView): updated size props #10970

Merged
merged 4 commits into from
Mar 14, 2022
Merged

chore(TreeView): updated size props #10970

merged 4 commits into from
Mar 14, 2022

Conversation

sstrubberg
Copy link
Member

@sstrubberg sstrubberg commented Mar 11, 2022 •
edited
Loading

REF #10295

  • Added FeatureFlag for size prop to only accept xs and sm
  • Added FeatureFlag for sm as a default for the size prop.
  • Added Controls functionality to Storybook story.
  • Changed compact to xs in styles.

image

Testing

  • Make sure everything is snappy in the v11 Storybook. Size controls should allow for xs and sm

@sstrubberg sstrubberg requested a review from a team as a code owner March 11, 2022 20:41
@netlify
Copy link

netlify bot commented Mar 11, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 475be84

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/622f7f50ab3efa0009d6f929

😎 Browse the preview: https://deploy-preview-10970--carbon-react-next.netlify.app

@sstrubberg sstrubberg mentioned this pull request Mar 11, 2022
Closed
36 tasks
@netlify
Copy link

netlify bot commented Mar 11, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 475be84

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/622f7f5071bf0f0009597256

😎 Browse the preview: https://deploy-preview-10970--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 11, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 475be84

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/622f7f50c5e83e0008836b87

😎 Browse the preview: https://deploy-preview-10970--carbon-components-react.netlify.app

tay1orjones
tay1orjones approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor usage change for InlineNotification, but otherwise looks good

@sstrubberg @tay1orjones
Update packages/react/src/components/TreeView/next/Treeview.stories.js
47db1e8 
Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
@sstrubberg sstrubberg enabled auto-merge (squash) March 14, 2022 15:58
@sstrubberg sstrubberg merged commit f308fd7 into carbon-design-system:main Mar 14, 2022
@sstrubberg sstrubberg deleted the chore/treeview-size branch March 15, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@dakahn dakahn dakahn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sstrubberg @tay1orjones @dakahn