Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Akamai CDN for Plex #11002

Merged
merged 11 commits into from
Mar 22, 2022
Merged

Use Akamai CDN for Plex #11002

merged 11 commits into from
Mar 22, 2022

Conversation

tay1orjones
Copy link
Member

This removes the reliance on google fonts, instead loading Plex from Akamai CDN

We can cut this as an RC and check the website as a testing ground.

Changelog

Changed

  • replaced gstatic links with those from Akamai

Testing / Reviewing

  • All usage of plex across storybook, the elements previews, etc should now resolve from the Akamai server. You'll need to check in the dev tools if the fonts are being loaded from there and not locally.
  • Double check to ensure that the font-faces included are the same and we're not missing any

@tay1orjones tay1orjones requested a review from a team as a code owner March 16, 2022 20:53
@netlify
Copy link

netlify bot commented Mar 16, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: c13f653

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/62324e49b283e200088da255

😎 Browse the preview: https://deploy-preview-11002--carbon-react-next.netlify.app

@tay1orjones tay1orjones changed the base branch from main to v10 March 16, 2022 20:53
@tay1orjones tay1orjones added the version: 10 Issues pertaining to Carbon v10 label Mar 16, 2022
@tay1orjones
Copy link
Member Author

I just pushed an update to ensure we're using font-display: $carbon--font-display; where we were previously. @joshblack any idea why we use this for mono, sans, and serif, but not for sans condensed?

@joshblack
Copy link
Contributor

joshblack commented Mar 16, 2022 •
edited
Loading

@tay1orjones not sure on my end, definitely doesn't hurt to add

@netlify
Copy link

netlify bot commented Mar 16, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: c13f653

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6233d7df13f2c13a36d931a2

😎 Browse the preview: https://deploy-preview-11002--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 16, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: c13f653

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6233d7abee118f2f41d8511f

😎 Browse the preview: https://deploy-preview-11002--carbon-components-react.netlify.app

@tay1orjones tay1orjones mentioned this pull request Mar 17, 2022
Closed
@tay1orjones tay1orjones marked this pull request as draft March 18, 2022 00:45
@tay1orjones tay1orjones marked this pull request as ready for review March 18, 2022 00:45
@tay1orjones tay1orjones reopened this Mar 18, 2022
@davidicus davidicus mentioned this pull request Mar 18, 2022
Closed
@tay1orjones tay1orjones removed the request for review from jnm2377 March 18, 2022 18:47
@tay1orjones
Copy link
Member Author

@joshblack @dakahn status checks are now sorted and passing, ready for re-review

@kodiakhq kodiakhq bot merged commit 418681e into carbon-design-system:v10 Mar 22, 2022
tay1orjones added a commit to tay1orjones/carbon that referenced this pull request Mar 25, 2022
@tay1orjones
Use Akamai CDN for Plex (carbon-design-system#11002)
e5db8fa 
* feat(type): provide Plex through Akamai CDN

* docs(type): remove references to google fonts

* docs(type): clarify intended usage of Akamai CDN

* fix(type): ensure correct font-display

* fix(type): include url root

* fix(type): use font-display for sans condensed

* chore: false commit to re-kick v10 workflow actions

* revert: false commit to re-kick v10 workflow actions
kodiakhq bot added a commit that referenced this pull request Mar 29, 2022
@tay1orjones @kodiakhq
feat(type): update default type resolver to use Akamai CDN (#11070)
82c993f 
* Use Akamai CDN for Plex (#11002)

* feat(type): provide Plex through Akamai CDN

* docs(type): remove references to google fonts

* docs(type): clarify intended usage of Akamai CDN

* fix(type): ensure correct font-display

* fix(type): include url root

* fix(type): use font-display for sans condensed

* chore: false commit to re-kick v10 workflow actions

* revert: false commit to re-kick v10 workflow actions

* feat(type): update default type resolver to use Akamai CDN

* docs(type): akamai cdn updates

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@tay1orjones tay1orjones mentioned this pull request May 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@dakahn dakahn dakahn approved these changes

@jeffchew jeffchew Awaiting requested review from jeffchew

Assignees
No one assigned
Labels
status: ready to merge 🎉 version: 10 Issues pertaining to Carbon v10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tay1orjones @joshblack @jeffchew @dakahn