docs(react): update form story to fix or remove accessibility violations #11486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
joshblack
approved these changes
May 25, 2022
abbeyhrt
changed the title
jnm2377
approved these changes
May 27, 2022
abbeyhrt
changed the title
abbeyhrt
changed the title
kennylam
added a commit
to kennylam/carbon
that referenced
this pull request
Jul 30, 2024
### Description
Now that CSS logical properties are used throughout the project, there is no need for `rtl` artifacts to be built. This PR removes those builds.
### Changelog
**New**
- {{new thing}}
**Changed**
- {{changed thing}}
**Removed**
- remove `rtl` builds and artifacts
- remove Storybook `rtl` documentation
<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REF #11444
Updates form story to remove AC violations. Removes the toggle section because there is a known bug with AC Checker where it is not able to find the associated label for elements with the "switch" role and throws a false positive.
Testing / Reviewing
Go to default Form story and run AC checker and make sure there are no violations (besides the "Content is not in landmark" one)