docs(breadcrumb): add controls to story #11535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jnm2377
approved these changes
Jun 2, 2022
tay1orjones
requested changes
Jun 3, 2022
There was a problem hiding this comment.
Here's what I'm seeing:
childrenis still in the table, I think the intent was to remove it?classNameshould be a string, or no? I'm not up to speed on if that was a decision y'all made for the playground stories or not. My assumption is it should be a text box for a string.
|
@tay1orjones oops sorry for this late reply. Its ready for review |
tay1orjones
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11468
Add controls to breadcrumb playground
Changelog
Changed
Testing / Reviewing
Make sure breadcrumb is working as intended and playground controls work