fix(styles): emit correct values for component tokens in zones #11573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
abbeyhrt
approved these changes
Jun 8, 2022
jnm2377
approved these changes
Jun 8, 2022
kennylam
added a commit
to kennylam/carbon
that referenced
this pull request
Jul 30, 2024
…n-system#11573) * Fixing display of invalid-text and warn-text * chore(prettier): format code --------- Co-authored-by: Kenny Lam <909118+kennylam@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11550
This PR updates our zoning implementation to make sure that the correct values have been emitted for component tokens in zones. Previously, we were comparing component tokens to the current theme (
theme.$theme) instead of the theme of the zone we were in.Changelog
New
_zone.scssto capture component token use-caseChanged
_zone.scssimplementation to match based on current theme of zoneRemoved
Testing / Reviewing