Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): update wrapComponent to bring in usePrefix #11575

Merged

Conversation

joshblack
Copy link
Contributor

Closes #11504

Changelog

New

  • Add tests for wrapComponent

Changed

  • Update the following components that use wrapComponent and className
    • TableActionList
    • TableToolbarContent
    • HeaderGlobalBar
  • Update wrapComponent to support static and dynamic class names

Removed

Testing / Reviewing

  • Verify that components that use wrapComponent and className can have their selectors correctly prefixed

@joshblack joshblack requested a review from a team as a code owner June 7, 2022 20:17
@netlify
Copy link

netlify bot commented Jun 7, 2022

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit c62bb89
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62a215b768edf900099f2a0e
😎 Deploy Preview https://deploy-preview-11575--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool idea to update className to accept a function 👍 One question, otherwise LGTM

packages/react/src/tools/wrapComponent.js Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Jun 7, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit c62bb89
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62a215b78ec4cb0008d3e336
😎 Deploy Preview https://deploy-preview-11575--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dakahn dakahn enabled auto-merge (squash) June 9, 2022 15:46
@dakahn dakahn merged commit 22847c4 into carbon-design-system:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Prefix not working for TableToolbarContent
3 participants