Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles): add css folder to sideEffects #11608

Merged
merged 2 commits into from
Jun 14, 2022
Merged

feat(styles): add css folder to sideEffects #11608

merged 2 commits into from
Jun 14, 2022

Conversation

joshblack
Copy link
Contributor

Closes #11599

Add the css folder and files to sideEffects in package.json

Changelog

New

Changed

  • The sideEffects field in package.json now includes the css folder

Removed

@joshblack joshblack requested a review from a team as a code owner June 13, 2022 16:29
@netlify
Copy link

netlify bot commented Jun 13, 2022

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 1a85612
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62a8ad91dc11650008384319
😎 Deploy Preview https://deploy-preview-11608--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 13, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 1a85612
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62a8ad91c1e479000974304e
😎 Deploy Preview https://deploy-preview-11608--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@metonym
Copy link
Collaborator

metonym commented Jun 13, 2022

I was thinking about this and I now wonder if scss/**/*.css is a typo?

greping for .css files in packages/styles/scss yields no results.

find ./packages/styles/scss |grep -e "\.css"

@joshblack
Copy link
Contributor Author

@metonym I think it's in there to catch any "vendor" style CSS, originally I think we had flatpickr styles fall under there but we must have converted that file to .scss in the migration. In other words, since sass can import from scss or css it seemed important to capture both just in case.

Let me know if that makes sense!

@kodiakhq kodiakhq bot merged commit 45c41b7 into main Jun 14, 2022
@kodiakhq kodiakhq bot deleted the joshblack-patch-1 branch June 14, 2022 16:06
kennylam pushed a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
Co-authored-by: Anna Wen <54281166+annawen1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: @carbon/styles should include .css in side effects
5 participants