fix(ComposedModal): close modal with esc key when no element has focus #11609
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10193
After doing a bit of digging between
Modal
andComposedModal
it seems like thediv
needs atabIndex
in order foronKeyDown
events to fire.Changelog
Changed
tabIndex
to the outerComposedModal
div so that all keypress events are capturedTesting / Reviewing
Open
ComposedModal with State Manager
example. Open the Modal, click on the text (to lose focus from the input), and try closing the modal with the esc key