Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(link): provide playground with working controls #11614

Merged
merged 4 commits into from
Jun 17, 2022

Conversation

tay1orjones
Copy link
Member

Closes #11464

Changelog

Changed

  • rename story file to *.stories.js
  • added args/argTypes for controls
  • added explicit defaults so docgen will pick them up and render them in the defaults column

Testing / Reviewing

  • Link stories
    • should look and function as expected
    • should have working controls for all expected props (no children or renderIcon, etc.)

@tay1orjones tay1orjones requested a review from a team as a code owner June 14, 2022 02:59
@netlify
Copy link

netlify bot commented Jun 14, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8f6ce6f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62acac53df391e0008cf7ca0
😎 Deploy Preview https://deploy-preview-11614--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 14, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 8f6ce6f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62acac533372520008108ec3
😎 Deploy Preview https://deploy-preview-11614--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@aledavila aledavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 🚢

@kodiakhq kodiakhq bot merged commit 76faa44 into carbon-design-system:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

components/Link/Link-story.js
4 participants