Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Skeleton): update SkeletonPlaceholder, SkeletonText, SkeletonIcon & IconSkeleton tests to RTL #11632

Merged
merged 5 commits into from
Jun 22, 2022

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Jun 16, 2022

Closes #11559
Closes #11629
Closes #11630

Changelog

New

  • tests for IconSkeleton (these were not here before)

Changed

update to RTL:

  • SkeletonIcon
  • SkeletonPlaceholder
  • SkeletonText

Testing / Reviewing

  • ensure all tests pass

@netlify
Copy link

netlify bot commented Jun 16, 2022

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 4e691f1
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62b376e38625e50008a3e0b4
😎 Deploy Preview https://deploy-preview-11632--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 16, 2022

Deploy Preview for carbon-elements failed.

Name Link
🔨 Latest commit 4e691f1
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62b376e3c49dcc00080475e9

@jnm2377 jnm2377 marked this pull request as ready for review June 16, 2022 21:01
@jnm2377 jnm2377 requested a review from a team as a code owner June 16, 2022 21:01
Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit 413adc4 into carbon-design-system:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants