fix(upgrade): move jscodeshift to external hard dep #11634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Do we need to worry about these warnings at all? I tried pulling it down and running it and didn't see any issues 🤔 To be safe, we could totally move jscodeshift to deps and keep as it external. Curious what your preference would be |
|
@joshblack Yeah as I look into it more I think it's safer to have a hard dep and mark it external. I'll update the PR |
tay1orjones
changed the title
joshblack
approved these changes
Jun 17, 2022
abbeyhrt
approved these changes
Jun 21, 2022
kennylam
pushed a commit
to kennylam/carbon
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surfaced in slack
Changelog
Changed
Testing / Reviewing
Pull this down, run
yarn buildinpackages/upgrade, inspect the built cli.js file and cmd+f forjscodeshift, it should be listed as a dependency