Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): check if dropdown is open before stopping propagation #11715

Merged
merged 4 commits into from
Jul 7, 2022

Conversation

abbeyhrt
Copy link
Contributor

Closes #10712

Same as #11701 but in v11.

Changelog

New

  • {{new thing}}

Changed

  • {{change thing}}

Removed

  • {{removed thing}}

Testing / Reviewing

Go to FilterableMultiselect story and open one of them and then open another one by clicking the chevron and confirm that the previously open dropdown closes. I'll update the story before this is merged

@abbeyhrt abbeyhrt requested a review from a team as a code owner June 29, 2022 20:14
@abbeyhrt abbeyhrt requested review from tw15egan and dakahn June 29, 2022 20:14
@netlify
Copy link

netlify bot commented Jun 29, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4d7260c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62c708d1c5ed4600081587af
😎 Deploy Preview https://deploy-preview-11715--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 29, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 4d7260c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62c708d03485b30009932238
😎 Deploy Preview https://deploy-preview-11715--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit 2a5586d into carbon-design-system:main Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: FilterableMultiSelect not collapsing when selecting another FilterableMultiSelect
4 participants