feat(FluidTextArea): adds new fluid text area #12053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
aagonzales
reviewed
Sep 12, 2022
There was a problem hiding this comment.
Looking good just a few things
Component
- Should the resize handle feature also be disabled in the disabled state?
- Error + focus state: when an input with an error state receives focus the border should turn blue/
$focusto indicate its been given focus. This is what we do across invalid states with the default inputs.
- As of Friday, I added in a Skeleton state for all the fluid input. It was an oversite in the original spec, so can we add that in now?
Storybook
- Can we add a
$layer-01background behind the second example?
tay1orjones
approved these changes
Sep 26, 2022
packages/react/src/components/FluidTextArea/FluidTextArea.stories.js
Outdated
Show resolved
Hide resolved
aagonzales
approved these changes
Sep 26, 2022
jnm2377
approved these changes
Sep 27, 2022
jnm2377
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: one more review 👀
status: visual review 🔍
labels
|
@aagonzales yea i think theres an issue to look at with layers and adding backgrounds unrelated to text area. so we will take a look at that in a separate issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12020
Closes #12018
Adds fluid text area