Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Notification): add HCM query for close icon #12097

Merged
merged 3 commits into from
Sep 16, 2022

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Sep 14, 2022

Closes #10199
Refs #11557

Adds in media query so that actionable notification close button is visible

image (5)
image (7)
image (6)

Changelog

New

  • Selector to target the close icon in all Notification variants

Testing / Reviewing

Enable WIndows HCM (Light theme - Desert) and check out the Notification story. All controls should be visible.

@netlify
Copy link

netlify bot commented Sep 14, 2022

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 645160b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6324b4660eb1dd0008e1dbb9
😎 Deploy Preview https://deploy-preview-12097--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 14, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 645160b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6324b4660933b60008a12214
😎 Deploy Preview https://deploy-preview-12097--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! LGTM
Captura de Pantalla 2022-09-16 a la(s) 12 34 16 p m
Captura de Pantalla 2022-09-16 a la(s) 12 34 24 p m
Captura de Pantalla 2022-09-16 a la(s) 12 34 31 p m

Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kodiakhq kodiakhq bot merged commit 900a9be into carbon-design-system:main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: After high contrast with white is activated, the close icon is invisible
4 participants