-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Accordion): update Accordion styles to match spec #12148
fix(Accordion): update Accordion styles to match spec #12148
Conversation
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Both issues are fixed! Thank you @tw15egan 🎉 🎉 🎉 |
@aagonzales, do we just need to update the spec on the website re: |
Yeah after looking at it a little more I think we should keep it |
d46a13a
to
16fbf3f
Compare
4217276
to
aed7104
Compare
aed7104
to
bd7b1b8
Compare
0304d46
to
fa704cd
Compare
Closes #12141
Closes #12223
Fixes a few style issues with
Accordion
Changelog
Changed
lg
sizeAccordion
is now center aligned$background-hover
, not$layer-hover
Testing / Reviewing
lg
, ensure the text and chevron are alignedAccordionItem
and ensure the token is$background-hover
on the::before
elementcc @shixiedesign